From 4a3c6c74b5f791cc29157ce1d01d7f12e955477a Mon Sep 17 00:00:00 2001 From: Jonathan Brassow Date: Mon, 20 Dec 2010 20:23:33 -0500 Subject: [RESEND][PATCH v3 3/8] md/raid5: use sysfs_notify_dirent_safe to avoid NULL pointer With the module parameter 'start_dirty_degraded' set, raid5_spare_active() previously called sysfs_notify_dirent() with a NULL argument (rdev->sysfs_state) when a rebuild finished. Signed-off-by: Jonathan Brassow Signed-off-by: Mike Snitzer --- drivers/md/raid5.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) NOTE: dm-devel seemingly ate the first v3 3/8, so resending diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index dc574f3..3219fd9 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -5339,7 +5339,7 @@ static int raid5_spare_active(mddev_t *mddev) && !test_bit(Faulty, &tmp->rdev->flags) && !test_and_set_bit(In_sync, &tmp->rdev->flags)) { count++; - sysfs_notify_dirent(tmp->rdev->sysfs_state); + sysfs_notify_dirent_safe(tmp->rdev->sysfs_state); } } spin_lock_irqsave(&conf->device_lock, flags); -- 1.7.2.3