From 4201219d3c1004264db9a7a124c663c962c1c896 Mon Sep 17 00:00:00 2001 From: Mike Snitzer Date: Mon, 5 Aug 2013 14:17:33 -0400 Subject: [PATCH 10/11] dm stats: small docs and FIXME --- drivers/md/dm-stats.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/md/dm-stats.c b/drivers/md/dm-stats.c index 2c30f78..3ec886b 100644 --- a/drivers/md/dm-stats.c +++ b/drivers/md/dm-stats.c @@ -193,6 +193,7 @@ static int dm_stats_create(struct dm_stats *st, sector_t start, sector_t end, return ret_id; } +// FIXME: factor locking out to caller or rename to dm_stats_find_and_lock() static struct dm_stat *dm_stats_find(struct dm_stats *st, int id) { struct dm_stat *m; @@ -452,8 +453,13 @@ static int dm_stats_print(struct dm_stats *st, int id, bool clear, s->tmp.io_ticks, s->tmp.time_in_queue ); - if (unlikely(sz + 1 >= maxlen)) + if (unlikely(sz + 1 >= maxlen)) { + /* + * NOTE: userspace will see the entire buffer is + * used and will retry with a larger buffer. + */ goto buffer_overflow; + } } if (clear) -- 1.7.1