From a3bbc0136db6b558289666e82ac949924f2e594c Mon Sep 17 00:00:00 2001 From: Mike Snitzer Date: Wed, 7 Aug 2013 09:55:51 -0400 Subject: [PATCH] dm stats: added FIXME about need to use of named slabs --- drivers/md/dm-stats.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/md/dm-stats.c b/drivers/md/dm-stats.c index 401fb06..95db7de 100644 --- a/drivers/md/dm-stats.c +++ b/drivers/md/dm-stats.c @@ -239,6 +239,15 @@ static int dm_stats_create(struct dm_stats *stats, sector_t start, sector_t end, if (n_entries != (size_t)n_entries || !(n_entries + 1)) return -EOVERFLOW; + /* + * FIXME: would _really_ prefer the use of dedicated slabs for kmalloc + * that way users can easily see why their memory is being heavily + * consumed. So looks like we'd need 3 slabs for: + * - dm_stat + * - dm_stat_shared + * - dm_stat_percpu + */ + shared_alloc_size = sizeof(struct dm_stat) + (size_t)n_entries * sizeof(struct dm_stat_shared); if ((shared_alloc_size - sizeof(struct dm_stat)) / sizeof(struct dm_stat_shared) != n_entries) return -EOVERFLOW; -- 1.7.1