From aaa6b295dc8e0197ec35a0e16a06faf7c8c08325 Mon Sep 17 00:00:00 2001 From: Heinz Mauelshagen Date: Mon, 14 Oct 2013 17:24:43 +0200 Subject: [PATCH 5/5] dm cache: optimize commit_if_needed Check commit_requested flag _before_ calling dm_cache_changed_this_transaction() superfluously. Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-cache-target.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux/drivers/md/dm-cache-target.c =================================================================== --- linux.orig/drivers/md/dm-cache-target.c +++ linux/drivers/md/dm-cache-target.c @@ -1324,8 +1324,8 @@ static int need_commit_due_to_time(struc static int commit_if_needed(struct cache *cache) { - if (dm_cache_changed_this_transaction(cache->cmd) && - (cache->commit_requested || need_commit_due_to_time(cache))) { + if ((cache->commit_requested || need_commit_due_to_time(cache)) && + dm_cache_changed_this_transaction(cache->cmd)) { atomic_inc(&cache->stats.commit_count); cache->last_commit_jiffies = jiffies; cache->commit_requested = false;