/* As a reference, before th patch, the following lines */ /* were showing up the check message: */ /* CHECK: Alignment should match open parenthesis */ /* #132: FILE: drivers/staging/vme_user/vme_bridge.h:132 */ /* #135: FILE: drivers/staging/vme_user/vme_bridge.h:135 */ /* #139: FILE: drivers/staging/vme_user/vme_bridge.h:139 */ /* #142: FILE: drivers/staging/vme_user/vme_bridge.h:142 */ /* #144: FILE: drivers/staging/vme_user/vme_bridge.h:144 */ /* #146: FILE: drivers/staging/vme_user/vme_bridge.h:146 */ /* #148: FILE: drivers/staging/vme_user/vme_bridge.h:148 */ /* #152: FILE: drivers/staging/vme_user/vme_bridge.h:152 */ /* #163: FILE: drivers/staging/vme_user/vme_bridge.h:163 */ /* #173: FILE: drivers/staging/vme_user/vme_bridge.h:173 */ /* #175: FILE: drivers/staging/vme_user/vme_bridge.h:175 */ $ pwd /home/alolivei/git/kernels/staging $ perl scripts/checkpatch.pl --strict -f drivers/staging/ CHECK: struct mutex definition without comment #31: FILE: drivers/staging/vme_user/vme_bridge.h:31: + struct mutex mtx; CHECK: struct mutex definition without comment #58: FILE: drivers/staging/vme_user/vme_bridge.h:58: + struct mutex mtx; CHECK: struct mutex definition without comment #64: FILE: drivers/staging/vme_user/vme_bridge.h:64: + struct mutex mtx; CHECK: struct mutex definition without comment #75: FILE: drivers/staging/vme_user/vme_bridge.h:75: + struct mutex mtx; WARNING: function definition argument 'int' should also have an identifier name #91: FILE: drivers/staging/vme_user/vme_bridge.h:91: + void (*func)(int, int, void*); WARNING: function definition argument 'int' should also have an identifier name #91: FILE: drivers/staging/vme_user/vme_bridge.h:91: + void (*func)(int, int, void*); WARNING: function definition argument 'void*' should also have an identifier name #91: FILE: drivers/staging/vme_user/vme_bridge.h:91: + void (*func)(int, int, void*); WARNING: function definition argument 'struct vme_slave_resource *' should also have an identifier name #131: FILE: drivers/staging/vme_user/vme_bridge.h:131: + int (*slave_get)(struct vme_slave_resource *, int *, unsigned long long *, WARNING: function definition argument 'int *' should also have an identifier name #131: FILE: drivers/staging/vme_user/vme_bridge.h:131: + int (*slave_get)(struct vme_slave_resource *, int *, unsigned long long *, WARNING: function definition argument 'unsigned long long *' should also have an identifier name #131: FILE: drivers/staging/vme_user/vme_bridge.h:131: + int (*slave_get)(struct vme_slave_resource *, int *, unsigned long long *, WARNING: function definition argument 'unsigned long long *' should also have an identifier name #131: FILE: drivers/staging/vme_user/vme_bridge.h:131: + int (*slave_get)(struct vme_slave_resource *, int *, unsigned long long *, WARNING: function definition argument 'dma_addr_t *' should also have an identifier name #131: FILE: drivers/staging/vme_user/vme_bridge.h:131: + int (*slave_get)(struct vme_slave_resource *, int *, unsigned long long *, WARNING: function definition argument 'u32 *' should also have an identifier name #131: FILE: drivers/staging/vme_user/vme_bridge.h:131: + int (*slave_get)(struct vme_slave_resource *, int *, unsigned long long *, WARNING: function definition argument 'u32 *' should also have an identifier name #131: FILE: drivers/staging/vme_user/vme_bridge.h:131: + int (*slave_get)(struct vme_slave_resource *, int *, unsigned long long *, CHECK: line length of 121 exceeds 100 columns #133: FILE: drivers/staging/vme_user/vme_bridge.h:133: + int (*slave_set)(struct vme_slave_resource *, int, unsigned long long, unsigned long long, dma_addr_t, u32, u32); WARNING: function definition argument 'struct vme_slave_resource *' should also have an identifier name #133: FILE: drivers/staging/vme_user/vme_bridge.h:133: + int (*slave_set)(struct vme_slave_resource *, int, unsigned long long, unsigned long long, dma_addr_t, u32, u32); WARNING: function definition argument 'int' should also have an identifier name #133: FILE: drivers/staging/vme_user/vme_bridge.h:133: + int (*slave_set)(struct vme_slave_resource *, int, unsigned long long, unsigned long long, dma_addr_t, u32, u32); WARNING: function definition argument 'unsigned long long' should also have an identifier name #133: FILE: drivers/staging/vme_user/vme_bridge.h:133: + int (*slave_set)(struct vme_slave_resource *, int, unsigned long long, unsigned long long, dma_addr_t, u32, u32); WARNING: function definition argument 'unsigned long long' should also have an identifier name #133: FILE: drivers/staging/vme_user/vme_bridge.h:133: + int (*slave_set)(struct vme_slave_resource *, int, unsigned long long, unsigned long long, dma_addr_t, u32, u32); WARNING: function definition argument 'dma_addr_t' should also have an identifier name #133: FILE: drivers/staging/vme_user/vme_bridge.h:133: + int (*slave_set)(struct vme_slave_resource *, int, unsigned long long, unsigned long long, dma_addr_t, u32, u32); WARNING: function definition argument 'u32' should also have an identifier name #133: FILE: drivers/staging/vme_user/vme_bridge.h:133: + int (*slave_set)(struct vme_slave_resource *, int, unsigned long long, unsigned long long, dma_addr_t, u32, u32); WARNING: function definition argument 'u32' should also have an identifier name #133: FILE: drivers/staging/vme_user/vme_bridge.h:133: + int (*slave_set)(struct vme_slave_resource *, int, unsigned long long, unsigned long long, dma_addr_t, u32, u32); WARNING: function definition argument 'struct vme_master_resource *' should also have an identifier name #136: FILE: drivers/staging/vme_user/vme_bridge.h:136: + int (*master_get)(struct vme_master_resource *, int *, unsigned long long *, WARNING: function definition argument 'int *' should also have an identifier name #136: FILE: drivers/staging/vme_user/vme_bridge.h:136: + int (*master_get)(struct vme_master_resource *, int *, unsigned long long *, WARNING: function definition argument 'unsigned long long *' should also have an identifier name #136: FILE: drivers/staging/vme_user/vme_bridge.h:136: + int (*master_get)(struct vme_master_resource *, int *, unsigned long long *, WARNING: function definition argument 'unsigned long long *' should also have an identifier name #136: FILE: drivers/staging/vme_user/vme_bridge.h:136: + int (*master_get)(struct vme_master_resource *, int *, unsigned long long *, WARNING: function definition argument 'u32 *' should also have an identifier name #136: FILE: drivers/staging/vme_user/vme_bridge.h:136: + int (*master_get)(struct vme_master_resource *, int *, unsigned long long *, WARNING: function definition argument 'u32 *' should also have an identifier name #136: FILE: drivers/staging/vme_user/vme_bridge.h:136: + int (*master_get)(struct vme_master_resource *, int *, unsigned long long *, WARNING: function definition argument 'u32 *' should also have an identifier name #136: FILE: drivers/staging/vme_user/vme_bridge.h:136: + int (*master_get)(struct vme_master_resource *, int *, unsigned long long *, WARNING: function definition argument 'struct vme_master_resource *' should also have an identifier name #138: FILE: drivers/staging/vme_user/vme_bridge.h:138: + int (*master_set)(struct vme_master_resource *, int, unsigned long long, WARNING: function definition argument 'int' should also have an identifier name #138: FILE: drivers/staging/vme_user/vme_bridge.h:138: + int (*master_set)(struct vme_master_resource *, int, unsigned long long, WARNING: function definition argument 'unsigned long long' should also have an identifier name #138: FILE: drivers/staging/vme_user/vme_bridge.h:138: + int (*master_set)(struct vme_master_resource *, int, unsigned long long, WARNING: function definition argument 'unsigned long long' should also have an identifier name #138: FILE: drivers/staging/vme_user/vme_bridge.h:138: + int (*master_set)(struct vme_master_resource *, int, unsigned long long, WARNING: function definition argument 'u32' should also have an identifier name #138: FILE: drivers/staging/vme_user/vme_bridge.h:138: + int (*master_set)(struct vme_master_resource *, int, unsigned long long, WARNING: function definition argument 'u32' should also have an identifier name #138: FILE: drivers/staging/vme_user/vme_bridge.h:138: + int (*master_set)(struct vme_master_resource *, int, unsigned long long, WARNING: function definition argument 'u32' should also have an identifier name #138: FILE: drivers/staging/vme_user/vme_bridge.h:138: + int (*master_set)(struct vme_master_resource *, int, unsigned long long, WARNING: function definition argument 'struct vme_master_resource *' should also have an identifier name #140: FILE: drivers/staging/vme_user/vme_bridge.h:140: + ssize_t (*master_read)(struct vme_master_resource *, void *, size_t, loff_t); WARNING: function definition argument 'void *' should also have an identifier name #140: FILE: drivers/staging/vme_user/vme_bridge.h:140: + ssize_t (*master_read)(struct vme_master_resource *, void *, size_t, loff_t); WARNING: function definition argument 'size_t' should also have an identifier name #140: FILE: drivers/staging/vme_user/vme_bridge.h:140: + ssize_t (*master_read)(struct vme_master_resource *, void *, size_t, loff_t); WARNING: function definition argument 'loff_t' should also have an identifier name #140: FILE: drivers/staging/vme_user/vme_bridge.h:140: + ssize_t (*master_read)(struct vme_master_resource *, void *, size_t, loff_t); WARNING: function definition argument 'struct vme_master_resource *' should also have an identifier name #141: FILE: drivers/staging/vme_user/vme_bridge.h:141: + ssize_t (*master_write)(struct vme_master_resource *, void *, size_t, loff_t); WARNING: function definition argument 'void *' should also have an identifier name #141: FILE: drivers/staging/vme_user/vme_bridge.h:141: + ssize_t (*master_write)(struct vme_master_resource *, void *, size_t, loff_t); WARNING: function definition argument 'size_t' should also have an identifier name #141: FILE: drivers/staging/vme_user/vme_bridge.h:141: + ssize_t (*master_write)(struct vme_master_resource *, void *, size_t, loff_t); WARNING: function definition argument 'loff_t' should also have an identifier name #141: FILE: drivers/staging/vme_user/vme_bridge.h:141: + ssize_t (*master_write)(struct vme_master_resource *, void *, size_t, loff_t); CHECK: line length of 115 exceeds 100 columns #142: FILE: drivers/staging/vme_user/vme_bridge.h:142: + unsigned int (*master_rmw)(struct vme_master_resource *, unsigned int, unsigned int, unsigned int, loff_t); WARNING: function definition argument 'struct vme_master_resource *' should also have an identifier name #142: FILE: drivers/staging/vme_user/vme_bridge.h:142: + unsigned int (*master_rmw)(struct vme_master_resource *, unsigned int, unsigned int, unsigned int, loff_t); WARNING: function definition argument 'unsigned int' should also have an identifier name #142: FILE: drivers/staging/vme_user/vme_bridge.h:142: + unsigned int (*master_rmw)(struct vme_master_resource *, unsigned int, unsigned int, unsigned int, loff_t); WARNING: function definition argument 'unsigned int' should also have an identifier name #142: FILE: drivers/staging/vme_user/vme_bridge.h:142: + unsigned int (*master_rmw)(struct vme_master_resource *, unsigned int, unsigned int, unsigned int, loff_t); WARNING: function definition argument 'unsigned int' should also have an identifier name #142: FILE: drivers/staging/vme_user/vme_bridge.h:142: + unsigned int (*master_rmw)(struct vme_master_resource *, unsigned int, unsigned int, unsigned int, loff_t); WARNING: function definition argument 'loff_t' should also have an identifier name #142: FILE: drivers/staging/vme_user/vme_bridge.h:142: + unsigned int (*master_rmw)(struct vme_master_resource *, unsigned int, unsigned int, unsigned int, loff_t); CHECK: line length of 105 exceeds 100 columns #145: FILE: drivers/staging/vme_user/vme_bridge.h:145: + int (*dma_list_add)(struct vme_dma_list *, struct vme_dma_attr *, struct vme_dma_attr *, size_t); WARNING: function definition argument 'struct vme_dma_list *' should also have an identifier name #145: FILE: drivers/staging/vme_user/vme_bridge.h:145: + int (*dma_list_add)(struct vme_dma_list *, struct vme_dma_attr *, struct vme_dma_attr *, size_t); WARNING: function definition argument 'struct vme_dma_attr *' should also have an identifier name #145: FILE: drivers/staging/vme_user/vme_bridge.h:145: + int (*dma_list_add)(struct vme_dma_list *, struct vme_dma_attr *, struct vme_dma_attr *, size_t); WARNING: function definition argument 'struct vme_dma_attr *' should also have an identifier name #145: FILE: drivers/staging/vme_user/vme_bridge.h:145: + int (*dma_list_add)(struct vme_dma_list *, struct vme_dma_attr *, struct vme_dma_attr *, size_t); WARNING: function definition argument 'size_t' should also have an identifier name #145: FILE: drivers/staging/vme_user/vme_bridge.h:145: + int (*dma_list_add)(struct vme_dma_list *, struct vme_dma_attr *, struct vme_dma_attr *, size_t); WARNING: function definition argument 'struct vme_dma_list *' should also have an identifier name #146: FILE: drivers/staging/vme_user/vme_bridge.h:146: + int (*dma_list_exec)(struct vme_dma_list *); WARNING: function definition argument 'struct vme_dma_list *' should also have an identifier name #147: FILE: drivers/staging/vme_user/vme_bridge.h:147: + int (*dma_list_empty)(struct vme_dma_list *); WARNING: function definition argument 'struct vme_bridge *' should also have an identifier name #150: FILE: drivers/staging/vme_user/vme_bridge.h:150: + void (*irq_set)(struct vme_bridge *, int, int, int); WARNING: function definition argument 'int' should also have an identifier name #150: FILE: drivers/staging/vme_user/vme_bridge.h:150: + void (*irq_set)(struct vme_bridge *, int, int, int); WARNING: function definition argument 'int' should also have an identifier name #150: FILE: drivers/staging/vme_user/vme_bridge.h:150: + void (*irq_set)(struct vme_bridge *, int, int, int); WARNING: function definition argument 'int' should also have an identifier name #150: FILE: drivers/staging/vme_user/vme_bridge.h:150: + void (*irq_set)(struct vme_bridge *, int, int, int); WARNING: function definition argument 'struct vme_bridge *' should also have an identifier name #151: FILE: drivers/staging/vme_user/vme_bridge.h:151: + int (*irq_generate)(struct vme_bridge *, int, int); WARNING: function definition argument 'int' should also have an identifier name #151: FILE: drivers/staging/vme_user/vme_bridge.h:151: + int (*irq_generate)(struct vme_bridge *, int, int); WARNING: function definition argument 'int' should also have an identifier name #151: FILE: drivers/staging/vme_user/vme_bridge.h:151: + int (*irq_generate)(struct vme_bridge *, int, int); WARNING: function definition argument 'struct vme_lm_resource *' should also have an identifier name #154: FILE: drivers/staging/vme_user/vme_bridge.h:154: + int (*lm_set)(struct vme_lm_resource *, unsigned long long, u32, u32); WARNING: function definition argument 'unsigned long long' should also have an identifier name #154: FILE: drivers/staging/vme_user/vme_bridge.h:154: + int (*lm_set)(struct vme_lm_resource *, unsigned long long, u32, u32); WARNING: function definition argument 'u32' should also have an identifier name #154: FILE: drivers/staging/vme_user/vme_bridge.h:154: + int (*lm_set)(struct vme_lm_resource *, unsigned long long, u32, u32); WARNING: function definition argument 'u32' should also have an identifier name #154: FILE: drivers/staging/vme_user/vme_bridge.h:154: + int (*lm_set)(struct vme_lm_resource *, unsigned long long, u32, u32); WARNING: function definition argument 'struct vme_lm_resource *' should also have an identifier name #155: FILE: drivers/staging/vme_user/vme_bridge.h:155: + int (*lm_get)(struct vme_lm_resource *, unsigned long long *, u32 *, u32 *); WARNING: function definition argument 'unsigned long long *' should also have an identifier name #155: FILE: drivers/staging/vme_user/vme_bridge.h:155: + int (*lm_get)(struct vme_lm_resource *, unsigned long long *, u32 *, u32 *); WARNING: function definition argument 'u32 *' should also have an identifier name #155: FILE: drivers/staging/vme_user/vme_bridge.h:155: + int (*lm_get)(struct vme_lm_resource *, unsigned long long *, u32 *, u32 *); WARNING: function definition argument 'u32 *' should also have an identifier name #155: FILE: drivers/staging/vme_user/vme_bridge.h:155: + int (*lm_get)(struct vme_lm_resource *, unsigned long long *, u32 *, u32 *); WARNING: function definition argument 'struct vme_lm_resource *' should also have an identifier name #156: FILE: drivers/staging/vme_user/vme_bridge.h:156: + int (*lm_attach)(struct vme_lm_resource *, int, void (*callback)(void *), void *); WARNING: function definition argument 'int' should also have an identifier name #156: FILE: drivers/staging/vme_user/vme_bridge.h:156: + int (*lm_attach)(struct vme_lm_resource *, int, void (*callback)(void *), void *); WARNING: function definition argument 'void *' should also have an identifier name #156: FILE: drivers/staging/vme_user/vme_bridge.h:156: + int (*lm_attach)(struct vme_lm_resource *, int, void (*callback)(void *), void *); WARNING: function definition argument 'struct vme_lm_resource *' should also have an identifier name #157: FILE: drivers/staging/vme_user/vme_bridge.h:157: + int (*lm_detach)(struct vme_lm_resource *, int); WARNING: function definition argument 'int' should also have an identifier name #157: FILE: drivers/staging/vme_user/vme_bridge.h:157: + int (*lm_detach)(struct vme_lm_resource *, int); WARNING: function definition argument 'struct vme_bridge *' should also have an identifier name #160: FILE: drivers/staging/vme_user/vme_bridge.h:160: + int (*slot_get)(struct vme_bridge *); WARNING: function definition argument 'struct vme_bridge *' should also have an identifier name #168: FILE: drivers/staging/vme_user/vme_bridge.h:168: +void vme_irq_handler(struct vme_bridge *, int, int); WARNING: function definition argument 'int' should also have an identifier name #168: FILE: drivers/staging/vme_user/vme_bridge.h:168: +void vme_irq_handler(struct vme_bridge *, int, int); WARNING: function definition argument 'int' should also have an identifier name #168: FILE: drivers/staging/vme_user/vme_bridge.h:168: +void vme_irq_handler(struct vme_bridge *, int, int); WARNING: function definition argument 'struct vme_bridge *' should also have an identifier name #170: FILE: drivers/staging/vme_user/vme_bridge.h:170: +struct vme_bridge *vme_init_bridge(struct vme_bridge *); WARNING: function definition argument 'struct vme_bridge *' should also have an identifier name #171: FILE: drivers/staging/vme_user/vme_bridge.h:171: +int vme_register_bridge(struct vme_bridge *); WARNING: function definition argument 'struct vme_bridge *' should also have an identifier name #172: FILE: drivers/staging/vme_user/vme_bridge.h:172: +void vme_unregister_bridge(struct vme_bridge *); CHECK: Lines should not end with a '(' #173: FILE: drivers/staging/vme_user/vme_bridge.h:173: +struct vme_error_handler *vme_register_error_handler( total: 0 errors, 77 warnings, 8 checks, 178 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. drivers/staging/vme_user/vme_bridge.h has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.