Merge target shouldn't allocate new exceptions: - make new method snapshot_merge_map that don't allocate exceptions. - modify __origin_write so that it doesn't allocate exceptions in merging snapshots. Signed-off-by: Mikulas Patocka Reviewed-by: Mike Snitzer --- drivers/md/dm-snap.c | 46 +++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 45 insertions(+), 1 deletion(-) Index: linux-2.6.31-fast-new-2/drivers/md/dm-snap.c =================================================================== --- linux-2.6.31-fast-new-2.orig/drivers/md/dm-snap.c 2009-10-16 21:51:42.000000000 +0200 +++ linux-2.6.31-fast-new-2/drivers/md/dm-snap.c 2009-10-16 21:51:45.000000000 +0200 @@ -147,6 +147,11 @@ static int bdev_equal(struct block_devic return lhs == rhs; } +static int snapshot_merge_map(struct dm_target *ti, struct bio *bio, + union map_info *map_context); + +#define is_merge(ti) ((ti)->type->map == snapshot_merge_map) + struct dm_snap_pending_exception { struct dm_exception e; @@ -1241,6 +1246,40 @@ static int snapshot_map(struct dm_target return r; } +static int snapshot_merge_map(struct dm_target *ti, struct bio *bio, + union map_info *map_context) +{ + struct dm_exception *e; + struct dm_snapshot *s = ti->private; + int r = DM_MAPIO_REMAPPED; + chunk_t chunk; + + chunk = sector_to_chunk(s->store, bio->bi_sector); + + down_read(&s->lock); + + /* Full snapshots are not usable */ + if (!s->valid) { + r = -EIO; + goto out_unlock; + } + + /* If the block is already remapped - use that */ + e = dm_lookup_exception(&s->complete, chunk); + if (e) { + remap_exception(s, e, bio, chunk); + goto out_unlock; + } + + bio->bi_bdev = s->origin->bdev; + + out_unlock: + up_read(&s->lock); + + return r; +} + + static int snapshot_end_io(struct dm_target *ti, struct bio *bio, int error, union map_info *map_context) { @@ -1360,6 +1399,11 @@ static int __origin_write(struct list_he /* Do all the snapshots on this origin */ list_for_each_entry (snap, snapshots, list) { + /* If the snapshot is merging, don't make new exceptions in it + - but in this case no one should be writing to the origin */ + if (is_merge(snap->ti)) + continue; + down_write(&snap->lock); /* Only deal with valid and active snapshots */ @@ -1587,7 +1631,7 @@ static struct target_type merge_target = .module = THIS_MODULE, .ctr = snapshot_ctr, .dtr = snapshot_dtr, - .map = snapshot_map, + .map = snapshot_merge_map, .end_io = snapshot_end_io, .resume = snapshot_resume, .status = snapshot_status,